Repository navigation
refactor(mobile): migrate all Hive boxes to Isar database - #2036
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
fyfrey
force-pushed
the
dev/migrate-all-hive-boxes-to-isar
branch
from
March 21, 2023 10:56
8a0cf41 to
193ca00
Compare
fyfrey
force-pushed
the
dev/migrate-all-hive-boxes-to-isar
branch
4 times, most recently
from
March 22, 2023 10:21
7c78224 to
1a1be61
Compare
martyfuhry
reviewed
Mar 22, 2023
martyfuhry
left a comment
martyfuhry
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! I haven't had the chance to run it here yet, but I will soon. Thanks!
fyfrey
force-pushed
the
dev/migrate-all-hive-boxes-to-isar
branch
from
March 22, 2023 16:45
1a1be61 to
c84d5bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all Hive usage across the mobile app and replaces it with the custom
Storeclass.The
Storeis now also type-safe.Migrations for existing Hive boxes are performed once on app start. After successful migration, the Hive boxes are removed.
We can delete the (generated) Hive classes and migration once enough releases have passed (so that users had a chance to update).