Skip to content

feat(mobile): Use new search API and GridView for Places / Locations - #2043

Merged
alextran1502 merged 7 commits into
mainfrom
feat/mobile-new-search
Mar 23, 2023
Merged

alextran1502 merged 7 commits into
mainfrom
feat/mobile-new-search

Conversation

@martyfuhry

@martyfuhry martyfuhry commented Mar 22, 2023 •

Copy link
Copy Markdown
Collaborator

Places and Things

  • Uses a GridView with 140 max extent, so wider displays will show more elements per row at a max size of 140 device pixels.
  • Same layout for Things, but I don't have any Things to show... I'm not sure if "Things" are relevant for the new search, so maybe they should be suppressed?
  • I didn't include the "broken image" looking element for when there are no places or things. I don't have any UI element to show that there are no places or things currently; it's just empty with the headers visible. I'd be happy to put something in for the empty element case!
  • Still shows the loading throbbers while waiting to load these in.

image

Search Results

  • Uses CLIP with the new SearchApi.
  • Didn't change anything else; they seem to show up in a "timeline" like view.

image

@vercel

vercel Bot commented Mar 22, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
immich ⬜️ Ignored (Inspect) Mar 23, 2023 at 3:02PM (UTC)

@martyfuhry
martyfuhry marked this pull request as draft March 22, 2023 03:32
@martyfuhry
martyfuhry marked this pull request as ready for review March 22, 2023 13:04
@martyfuhry
martyfuhry requested a review from alextran1502 March 22, 2023 13:04
@jrasm91

jrasm91 commented Mar 22, 2023

Copy link
Copy Markdown
Member

Can you add a screenshot?

@martyfuhry

Copy link
Copy Markdown
Collaborator Author

Can you add a screenshot?

I sure can! I didn't want to add a screenshot of the Explore Locations section for obvious reasons, but I can blur stuff out.

@jrasm91

jrasm91 commented Mar 22, 2023

Copy link
Copy Markdown
Member

Oh yeah, sounds good!

@alextran1502

alextran1502 commented Mar 23, 2023 •

Copy link
Copy Markdown
Member

@martyfuhry Thank you for the PR. The search integration is perfect, I love how minimal of a change we need to do.

I would like to keep the layout of the Places and Things to be horizontally scrolling but with some small tweak

  1. Only show the maximum of 4 results for each category. Then on the row where we put Things and Places, you can have a button to "View all" which then navigate to a different page to show all the entry with the grid layout that you have. This would keep the UI/UX similar to GPhotos's flow.
  2. The reason that it is showing in a horizontal fashion is that we will incorporate more grouping categories, like the Explore pages on the web. Here is how GPhotos does the grouping
    image

Can you help merge the branch the resolve conflicts? I just merged Fynn's branch in to swap out all the Hive usage.

@martyfuhry
martyfuhry force-pushed the feat/mobile-new-search branch from 3e88d8d to 3f474a1 Compare March 23, 2023 03:51
@martyfuhry

Copy link
Copy Markdown
Collaborator Author

I've made the adjustments:

  • I thought it was better to show (at most) 10 in a horizontally scrolling list here. I can change that, of course. For example, I could show all of them, or don't let you scroll at all. Up to you.
  • Tapping View all shows the grid view page.
  • When the curated content is empty, the grid just shows a broken image looking thing, just like in the search row.

Search Page
image

View More Grid Page
image

Empty Objects / Locations
image

@alextran1502
alextran1502 merged commit 32a065a into main Mar 23, 2023
@alextran1502
alextran1502 deleted the feat/mobile-new-search branch March 23, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants