Repository navigation
feat(mobile): Use new search API and GridView for Places / Locations - #2043
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
martyfuhry
marked this pull request as draft
March 22, 2023 03:32
martyfuhry
marked this pull request as ready for review
March 22, 2023 13:04
Member
|
Can you add a screenshot? |
Collaborator
Author
I sure can! I didn't want to add a screenshot of the Explore Locations section for obvious reasons, but I can blur stuff out. |
Member
|
Oh yeah, sounds good! |
Member
|
@martyfuhry Thank you for the PR. The search integration is perfect, I love how minimal of a change we need to do. I would like to keep the layout of the Places and Things to be horizontally scrolling but with some small tweak
Can you help merge the branch the resolve conflicts? I just merged Fynn's branch in to swap out all the Hive usage. |
martyfuhry
force-pushed
the
feat/mobile-new-search
branch
from
March 23, 2023 03:51
3e88d8d to
3f474a1
Compare
Collaborator
Author
|
I've made the adjustments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Places and Things
GridViewwith 140 max extent, so wider displays will show more elements per row at a max size of 140 device pixels.Search Results
SearchApi.