Skip to content

refactor(server): cron jobs - #2067

Merged
alextran1502 merged 1 commit into
mainfrom
refactor/cron-jobs
Mar 24, 2023
Merged

alextran1502 merged 1 commit into
mainfrom
refactor/cron-jobs

Conversation

@jrasm91

@jrasm91 jrasm91 commented Mar 24, 2023

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Mar 24, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
immich ⬜️ Ignored (Inspect) Mar 24, 2023 at 4:07AM (UTC)

//
{ provide: APP_GUARD, useExisting: AuthGuard },
AuthGuard,
AppCronJobs,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between having the Module be imported vs. as a provider in this case?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much, it is just one file, used in one place, with no depending, and not imported anywhere so there's no benefit to having a dedicated module for it.

@alextran1502
alextran1502 merged commit e36b620 into main Mar 24, 2023
@alextran1502
alextran1502 deleted the refactor/cron-jobs branch March 24, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants