You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(web): improve and refactor thumbnails - #2087
Currently there's some detection for horizontal and vertical asset orientation and sets the height/width accordingly. But I don't think exif data is actually present in a lot of cases and I'm not certain orientations like Rotate 90 CW are valid. Anyway, that still needs to be looked into further, but that's probably for a future PR.
Live photos would only play when hovering the top right icon, now plays when hovering anywhere (same as video)
This is the intended behavior for LivePhoto to play when hover on the icon
I understand, that's why I noted it as a change rather than a fix. Hovering over the icon to start playing live photos feels unintuitive to me, that's why I changed it. If you want however, it can be reverted.
Live photos would only play when hovering the top right icon, now plays when hovering anywhere (same as video)
This is the intended behavior for LivePhoto to play when hover on the icon
I understand, that's why I noted it as a change rather than a fix. Hovering over the icon to start playing live photos feels unintuitive to me, that's why I changed it. If you want however, it can be reverted.
Yes please, I would like to treat it as a normal photo, the motion part is extra and only run when you specifically want to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes are made:
And the following bugs are fixes:
0:5instead of0:05Currently there's some detection for horizontal and vertical asset orientation and sets the height/width accordingly. But I don't think exif data is actually present in a lot of cases and I'm not certain orientations like
Rotate 90 CWare valid. Anyway, that still needs to be looked into further, but that's probably for a future PR.