Repository navigation
feat(server): apply storage migration after exif completes - #2093
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
bo0tzz
left a comment
bo0tzz
left a comment
There was a problem hiding this comment.
handleTemplateMigration has a TODO about removing some livePhoto stuff, is that applicable yet? And if so, can that function be refactored just delegate to the single one?
bo0tzz
changed the title
|
The main thing is that live photos should use the same filename for both still and motion, but historically the original filename was only available on the still portion and the motion was just uuid. This "extra" code is to get the original name for a motion asset via "motion" (child) => "still" (parent) => "still exif.imageName". I think this has been fixed for new uploads (https://github.com/immich-app/immich/blob/main/server/apps/immich/src/api-v1/asset/asset.service.ts#L107), since motion assets should be saved with the still name now. However, I don't think that's the case for historic live photos, who are missing the original name and it's only available on the still part. |
|
I tried to upload LivePhotos, and the motion part doesn't get moved correctly to the Actual
Expected
|
alextran1502
left a comment
alextran1502
left a comment
There was a problem hiding this comment.
Error in moving LivePhotos
|
@alextran1502 - did a bit more testing with live photos and it seems to be working now. Feel free to retest. |
Apply storage migration after exif process saves
fileCreatedAt.