Repository navigation
feat: Add description - #2237
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jrasm91
reviewed
Apr 12, 2023
jrasm91
left a comment
jrasm91
left a comment
Member
There was a problem hiding this comment.
Can you add description to the typesense schema so it is searchable with m:?
| } | ||
|
|
||
| if (asset.exifInfo != null) { | ||
| asset.exifInfo.description = dto.description || ''; |
Member
There was a problem hiding this comment.
We should try avoid using an empty string, and just use null instead.
martyfuhry
reviewed
Apr 12, 2023
martyfuhry
left a comment
martyfuhry
left a comment
Collaborator
There was a problem hiding this comment.
I haven't tested this out yet but my wife's been bugging me for this feature. Looks awesome!
alextran1502
commented
Apr 12, 2023
…nto feat/add-description
* uses providers for description text * comments * fixes initial data setting * fixes notifier
|
I can't seem to find this on Android mobile app. Has it been removed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the "description" mechanism to the asset. It is functional on both the web and the mobile app.
m:descriptionFixes # (issue)
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: