Skip to content

feat(web): improve page header + scrolling - #2453

Merged
alextran1502 merged 3 commits into
mainfrom
fix/separator-line
May 17, 2023
Merged

alextran1502 merged 3 commits into
mainfrom
fix/separator-line

Conversation

@jrasm91

@jrasm91 jrasm91 commented May 17, 2023 •

Copy link
Copy Markdown
Member

Extend line to edge of the screen between page title and content. Also, the content scrolls after the title. The sidemenu also now scrolls similarly.

image
image

image
image

image
image

@vercel

vercel Bot commented May 17, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) May 17, 2023 7:14pm

@michelheusschen

Copy link
Copy Markdown
Collaborator

This moves the whole user layout a bit to the right, not only the line. The map view now touches the right edge for example. Is that intended?

@jrasm91 jrasm91 changed the title fix: line to edge of screen feat(web): improve page header + scrolling May 17, 2023
@jrasm91

jrasm91 commented May 17, 2023

Copy link
Copy Markdown
Member Author

This moves the whole user layout a bit to the right, not only the line. The map view now touches the right edge for example. Is that intended?

No, it turns out I wanted the line to extend, the header to be sticky, and the content to have it's own scroll context. I've updated the user layout component to work like this now.

@alextran1502 alextran1502 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you

@alextran1502
alextran1502 merged commit 4a00520 into main May 17, 2023
@alextran1502
alextran1502 deleted the fix/separator-line branch May 17, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants