Repository navigation
feat(server): option to transcode to original resolution - #2709
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jrasm91
reviewed
Jun 10, 2023
jrasm91
approved these changes
Jun 10, 2023
jrasm91
left a comment
jrasm91
left a comment
Member
There was a problem hiding this comment.
Looks great. I'd be fine also adding a fallback value to the targetResolution in the case that the value is invalid for whatever reason. But we could also do that in a separate PR.
Member
Author
|
For now it's probably best to leave it as-is. If it's NaN but also not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2707, allowing users to transcode without setting a target resolution. Specifically, a new option is added for target resolution: "original".