Repository navigation
refactor(server, web): create shared link - #2879
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jrasm91
force-pushed
the
refactor/create-shared-link
branch
from
June 20, 2023 18:02
a5a5074 to
1fe0417
Compare
jrasm91
force-pushed
the
refactor/create-shared-link
branch
from
June 20, 2023 18:36
1fe0417 to
58d90f2
Compare
uhthomas
reviewed
Jun 20, 2023
|
|
||
| <section class="m-6"> | ||
| {#if !isShowSharedLink} | ||
| {#if !sharedLink} |
Collaborator
There was a problem hiding this comment.
Would a flattened chain like this make more sense?
{#if sharedLink}
{:else if editingLink}
{:else}
{/if}
Member
Author
There was a problem hiding this comment.
Maybe. I think there should be separate components for create vs edit myself.
alextran1502
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.