Repository navigation
fix(web): Add m: to search query upon loading results. - #2954
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
uhthomas
reviewed
Jun 25, 2023
aero31aero
force-pushed
the
01-clip-status
branch
2 times, most recently
from
June 25, 2023 22:25
9f7e1d3 to
fcfeedd
Compare
|
|
||
| $: term = $page.url.searchParams.get('q') || data.term || ''; | ||
| $: is_metadata_search = $page.url.searchParams.get('clip') === 'false'; | ||
| $: term = `${!is_metadata_search && term !== '' ? 'm:' : ''}${term}`; |
Member
There was a problem hiding this comment.
Here is the error I got when trying to run this
Contributor
Author
There was a problem hiding this comment.
I see. This is my first time with reactive statements; I figured it was a false warning since the typescript compiled properly. I just switched to an anonymous function with better legibility.
Previously, we'd drop the m: from non-clip searches entirely. This behavior incorrectly represents the page's status (results from non-clip search but query implies a clip search). Also, any follow-up searches change to clip searches, which feels like a jarring UX if you have to add m: every time in a 'search-session'.
aero31aero
force-pushed
the
01-clip-status
branch
from
June 26, 2023 18:21
fcfeedd to
74f5e68
Compare
alextran1502
approved these changes
Jun 28, 2023
alextran1502
enabled auto-merge (squash)
June 28, 2023 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we'd drop the m: from non-clip searches entirely. This behavior incorrectly represents the page's status (results from non-clip search but query implies a clip search). Also, any follow-up searches change to clip searches, which feels like a jarring UX if you have to add m: every time in a 'search-session'.