Skip to content

refactor(server)!: add/remove album assets - #3109

Merged
alextran1502 merged 10 commits into
mainfrom
refactor/album-assets
Aug 2, 2023
Merged

alextran1502 merged 10 commits into
mainfrom
refactor/album-assets

Conversation

@jrasm91

@jrasm91 jrasm91 commented Jul 4, 2023 •

Copy link
Copy Markdown
Member

Breaking Change: Mobile app and server must both be up to date

If the mobile app and server are out of sync the following will no longer work:

  • Add assets to albums
  • Remove assets from albums

TODO:

  • Unit tests
  • Web testing
  • Mobile testing
  • Perf testing
  • Access testing
  • Test removing current thumbnail

Test Scenarios

  • Add own assets to album
  • Remove own assets from album
  • Add own assets to a non-owned, shared album
  • Drag and drop new assets to a non-owned, shared album (lots of notifications)
  • Remove own assets from a non-owned, shared album (new feature 🎉)
  • Remove a partner shared asset from a non-owned, shared album (via API confirmed no remove access without partner sharing and confirmed removed success with partner sharing)
  • Remove current thumbnail asset from album and verify new thumbnail is set
  • Remove last asset from album and verify album has null thumbnail

Mobile Testing

  • Add asset(s) from album viewer (owned/shared)
  • Add asset(s) from the timeline (owned/shared)
  • Add asset from the detail viewer (owned/shared)
  • Remove asset(s) from the album viewer (owned)
  • Add asset(s) from the web and check the presence on the mobile app

@vercel

vercel Bot commented Jul 4, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 9:53pm

@jrasm91
jrasm91 force-pushed the refactor/album-assets branch from c2c51e3 to 1fa52da Compare July 6, 2023 01:59
@jrasm91
jrasm91 requested a review from alextran1502 July 6, 2023 03:01
@jrasm91 jrasm91 changed the title refactor(server): add/remove album assets refactor(server)!: add/remove album assets Jul 6, 2023
@jrasm91
jrasm91 requested a review from brighteyed July 6, 2023 03:06
@jrasm91
jrasm91 force-pushed the refactor/album-assets branch from 0d37634 to c19b71c Compare July 14, 2023 03:25
@alextran1502

Copy link
Copy Markdown
Member

@jrasm91 When you have time, can you help rebase this? I can look at this PR now

@jrasm91
jrasm91 force-pushed the refactor/album-assets branch from f5dc8e0 to 578b26e Compare August 1, 2023 16:01
@jrasm91

jrasm91 commented Aug 1, 2023

Copy link
Copy Markdown
Member Author

@jrasm91 When you have time, can you help rebase this? I can look at this PR now

Should be good to go now. Thanks.

@alextran1502 alextran1502 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@alextran1502
alextran1502 marked this pull request as ready for review August 2, 2023 01:29
@alextran1502
alextran1502 merged commit b9cda59 into main Aug 2, 2023
@alextran1502
alextran1502 deleted the refactor/album-assets branch August 2, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants