Repository navigation
fix(web): ContextMenu unsatisfying UI behaviors - #3787
Merged
Merged
Conversation
Now the button behavior is the same as that of `AccountInfoPanel` - Before: double-click button don't close ContextMenu, only click outside does. - Now: both double-click button and click outside does close ContextMenu Ref: Issue immich-app#3735
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jrasm91
approved these changes
Aug 20, 2023
martabal
pushed a commit
that referenced
this pull request
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made in this PR
Related Issue #3735
1. Fix opened
ContextMenublocks navigation barLike the issue mentioned
ContextMenublocks. I surveyed similarAccountInfoPanel, and found it is also a absolute panel with fixed 75px top value, so I chose to fix it this way.2. Both double-click on the button and click outside does close
ContextMenuAs I was fixing the first bug, I found double-click on the button doesn't close
ContextMenu, which doesn't match with the behavior ofAccountInfoPanel's button. So I coded a fix as well.How has it been tested
Run
npm run check:alllocally for web.Demo
Screen.Recording.2023-08-19.at.10.34.41.PM.mov