Skip to content

feat(web): slideshow mode - #3813

Merged
alextran1502 merged 2 commits into
mainfrom
feat/slide-show
Aug 25, 2023
Merged

alextran1502 merged 2 commits into
mainfrom
feat/slide-show

Conversation

@alextran1502

@alextran1502 alextran1502 commented Aug 21, 2023 •

Copy link
Copy Markdown
Member

This PR implements slideshow mode, which is played from the asset viewer component and it will:

  • Entering fullscreen mode
  • Autostart progress bar, default is 5 seconds
  • Auto transition to next asset
  • Stop and exit fullscreen mode at the end of the page.
  • Wait for video to finish playing before advancing in navigation
Screen.Recording.2023-08-23.at.07.56.51-1.mov

Todo

  • timeline
  • album
  • archive
  • favorite
  • face's assets

@vercel

vercel Bot commented Aug 21, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 7:44pm

@alextran1502
alextran1502 marked this pull request as ready for review August 23, 2023 05:58
slideshow for main screen

Added control buttons

update

close detail panel window sif opened

format

5 seconds

remove unused files

handle video player

format
@jrasm91
jrasm91 force-pushed the feat/slide-show branch 2 times, most recently from aee685d to c2b0275 Compare August 25, 2023 19:43

@jrasm91 jrasm91 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks real nice!

@alextran1502
alextran1502 merged commit e18a9f8 into main Aug 25, 2023
@alextran1502
alextran1502 deleted the feat/slide-show branch August 25, 2023 23:20
martabal pushed a commit that referenced this pull request Sep 11, 2023
* slideshow

slideshow for main screen

Added control buttons

update

close detail panel window sif opened

format

5 seconds

remove unused files

handle video player

format

* fix: restrict slideshow to timeline views

---------

Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
@Danie10

Danie10 commented Dec 25, 2023

Copy link
Copy Markdown

Will it be possible for anyone to run the slideshow for a shared album too? Right now only the album owner seems to see the slideshow option.

@egutierrez-ar

Copy link
Copy Markdown

Will it be possible for anyone to run the slideshow for a shared album too? Right now only the album owner seems to see the slideshow option.

Hey everyone, I also have the same wish as @Danie10
It seems like a simple overlooked feature in the shared gallery screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants