Repository navigation
feat(server): asset entity audit - #3824
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
fyfrey
force-pushed
the
dev/audit-endpoint
branch
from
August 21, 2023 22:20
755bc00 to
fc338c2
Compare
fyfrey
marked this pull request as ready for review
August 22, 2023 17:14
Member
|
What is the difference between the two new endpoints and do we need them both? Can we keep all the audit stuff in one controller/service? |
jrasm91
reviewed
Aug 22, 2023
Collaborator
Author
|
Many thanks for the review @jrasm91 Regarding the new endpoints: I guess we actually don't need the audit controller at all (and only keep getChanges in the asset controller). Or would you prefer to move getChanges to the audit controller (as it's only method). The audit service only needs the cleanup method for the Cron job (unless I move getChanges to the audit controller) |
1 of 3 tasks
fyfrey
force-pushed
the
dev/audit-endpoint
branch
from
August 24, 2023 06:49
443a357 to
e78b273
Compare
jrasm91
approved these changes
Aug 24, 2023
jrasm91
force-pushed
the
dev/audit-endpoint
branch
from
August 24, 2023 18:27
b952a0d to
d330bcf
Compare
martabal
pushed a commit
that referenced
this pull request
Sep 11, 2023
* feat(server): audit log * feedback * Insert to database * migration * test * controller/repository/service * test * module * feat(server): implement audit endpoint * directly return changed assets * add daily cleanup of audit table * fix tests * review feedback * ci * refactor(server): audit implementation * chore: open api --------- Co-authored-by: Alex Tran <alex.tran1502@gmail.com> Co-authored-by: Fynn Petersen-Frey <zoodyy@users.noreply.github.com> Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continues from #3592 (rebased)
Features:
updatedAfterquery paramTested Scenarios:
needsFullSyncis true