Skip to content

fix(admin-cli): Fixes immich-admin because npm bin does not like arguments - #3864

Merged
alextran1502 merged 3 commits into
immich-app:mainfrom
danieldietzler:main
Aug 27, 2023
Merged

alextran1502 merged 3 commits into
immich-app:mainfrom
danieldietzler:main

Conversation

@danieldietzler

Copy link
Copy Markdown
Member

This addresses the broken immich-admin cli.

Closes #3715.

@vercel

vercel Bot commented Aug 25, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2023 10:57am

@jrasm91 jrasm91 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! How have you tested it?

Comment thread server/admin-cli.sh Outdated
@@ -0,0 +1,2 @@
#!/usr/bin/env sh

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file executable? It should have the same permissions as the other scripts.

Also, could you move it to the bin folder?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has the same permissions as all the other scripts in bin.

@danieldietzler

danieldietzler commented Aug 26, 2023 •

Copy link
Copy Markdown
Member Author

Thanks for picking this up! How have you tested it?

Well..... now the arguments are actually passed, thanks for the catch!

About other options: I've tried stuff like ./start.sh -- admin-cli but nothing seemed to work and after reading a bit it appears that npm bin just symlinks to the specified file. So it appears there is virtually no way to pass arguments without an intermediate script.

@danieldietzler
danieldietzler requested a review from jrasm91 August 26, 2023 15:55
@alextran1502

Copy link
Copy Markdown
Member

Tested with make prod then attached to the container's shell and ran two commands. Seems to work fine now

image

@alextran1502
alextran1502 merged commit 7097cf6 into immich-app:main Aug 27, 2023
martabal pushed a commit that referenced this pull request Sep 11, 2023
…ments (#3864)

* fix admin cli

* move script to bin, actually pass arguments

* remove accidentally created package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] immich-admin

3 participants