Repository navigation
feat(web): hide face from detail page - #4098
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jrasm91
left a comment
jrasm91
left a comment
There was a problem hiding this comment.
This looks fine. In general we have this pattern in the web app where we often have the same action available a few different places. For people, the exact same action seems to exist in the all people page > menu option and now person page > menu option. I don't think we need two different implementations of the same action.
For assets, we consolidated some of this code by creating the photos-page/*-action.svelte components. They encapsulate the action, call the api endpoint, and show the notification. They have callbacks afterwards so the parent component can do redirects or other state management if needed. It would be great to do the same for these people actions.
Changes made in this PR
This PR adds the ability to hide a face from the detail page. Once the face is hidden, the user is redirected to the Explore page.
Closes #4099
Screenshots