Repository navigation
fix(web): Uses asset exif info for desc in asset viewer - #4249
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Member
|
Did you test navigating to the next/previous assets, opening and closing the asset in each view? |
Contributor
Author
|
Ohhhhh nice catch ty! next/prev doesnt show the description, working on it |
Member
|
Stale, closing. Feel free to re-open if you find a way to make this work correctly. |
Member
|
Oh you know what, I mis-read that you had actually already fixed my comment. I tested this and it does indeed allow for descriptions in shared links. |
jrasm91
force-pushed
the
4073-BetterDesc
branch
from
January 12, 2024 20:24
3835d87 to
3612659
Compare
jrasm91
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
asset's exifInfo.description in the bound description (When it exists)Fixes #4073
Fixes #6244
How Has This Been Tested?
sorry for the buggy PR @waclaw66 Any other test paths you want me to exercise?
Screenshots (if appropriate):
Left: As Photo Middle: As photo owner through shared link Right: As anon user in incognito



Tested the photo detail when people are present to exercise the code within the if statement
After editing description just to make sure the detail is updated properly
Checklist: