Skip to content

fix(server,cli): don't float promises - #4433

Merged
jrasm91 merged 5 commits into
mainfrom
fix/dont-float-promises
Oct 13, 2023
Merged

jrasm91 merged 5 commits into
mainfrom
fix/dont-float-promises

Conversation

@etnoy

@etnoy etnoy commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

Should this be done on the web, too?

@vercel

vercel Bot commented Oct 11, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 9:27am

@jrasm91 jrasm91 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minus the archive one this looks good, thank you.

Comment thread server/src/domain/asset/asset.service.ts Outdated
@etnoy

etnoy commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator Author

Minus the archive one this looks good, thank you.

I can't even remember if I fixed this one, could you check for me?

@jrasm91
jrasm91 merged commit f0bb50b into main Oct 13, 2023
@jrasm91
jrasm91 deleted the fix/dont-float-promises branch October 13, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants