Repository navigation
fix(mobile): asset deletion state management - #4568
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
fyfrey
reviewed
Oct 22, 2023
fyfrey
left a comment
fyfrey
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this certainly improves the delete handling + robustness. I've found two small code optimization opportunities
fyfrey
approved these changes
Oct 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed made in the PR
The previous handling removed local assets from DB even if the user denied the System prompt which is undesirable. This resulted in few different scenarios where the actual state of the asset is different from the one maintained in the DB.
Few such cases:
remoteDeletedwill not be emptyThese are handled in the updated handling.
During sync, remote deleted asset details were not removed from
ExifInfotable which is properly cleaned now.Emptying trash removed local assets without asking a prompt. The state is now properly updated to mark them as not backed up instead.