Skip to content

refactor(mobile): stack only through merging from timeline - #4598

Merged
alextran1502 merged 3 commits into
mainfrom
fix/stack-requires-two-assets
Oct 22, 2023
Merged

alextran1502 merged 3 commits into
mainfrom
fix/stack-requires-two-assets

Conversation

@shenlong-tanwen

Copy link
Copy Markdown
Member

Changes made in the PR

  • Asset selection based handling is removed for stacking since selecting multiple assets and stacking them from the timeline is more natural.
  • Show stack button only when at-least two assets are selected in the timeline
  • Sort stack children by their fileCreateAt time

Note

The previous asset selection page based handling allowed one to remove multiple children by deselecting them from the asset selection page. With this change, children can only be removed one at a time or the entire group can be un-stacked and re-stacked.

@vercel

vercel Bot commented Oct 22, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
immich ⬜️ Ignored (Inspect) Oct 22, 2023 4:18pm

@alextran1502
alextran1502 merged commit 9b41864 into main Oct 22, 2023
@alextran1502
alextran1502 deleted the fix/stack-requires-two-assets branch October 22, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants