Repository navigation
feat(web,server): activity - #4682
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
0eb9a5b to
7d74eb4
Compare
jrasm91
left a comment
jrasm91
left a comment
There was a problem hiding this comment.
Can you make the activity controller more restful please? You should never have two named parameters immediately adjacent to each other. Ideally just resource/:id
Should I set the assetId or the albumId in the Body ? |
|
When you create a new item via post, yes those should be in the body. When you query for them they should be query params. If album id is required on every single route, you should consider changing the endpoints to be something like /album/:id/activity/:activityId and call it AlbumActivity instead. |
Thanks for the clarification, I appreciate it |
87a558e to
a740a28
Compare
a740a28 to
3ef70c6
Compare
1fa4c82 to
d3a5f81
Compare
d3a5f81 to
c939d31
Compare
96d95b8 to
fbdf7a0
Compare
alextran1502
left a comment
alextran1502
left a comment
There was a problem hiding this comment.
Amazing work! Thank you all!
* feat: activity * regenerate api * fix: make asset owner unable to delete comment * fix: merge * fix: tests * feat: use textarea instead of input * fix: do actions only if the album is shared * fix: placeholder opacity * fix(web): improve messages UI * fix(web): improve input message UI * pr feedback * fix: tests * pr feedback * pr feedback * pr feedback * fix permissions * regenerate api * pr feedback * pr feedback * multiple improvements on web * fix: ui colors * WIP * chore: open api * pr feedback * fix: add comment * chore: clean up * pr feedback * refactor: endpoints * chore: open api * fix: filter by type * fix: e2e * feat: e2e remove own comment * fix: web tests * remove console.log * chore: cleanup * fix: ui tweaks * pr feedback * fix web test * fix: unit tests * chore: remove unused code * revert useless changes * fix: grouping messages * fix: remove nullable on updatedAt * fix: text overflow * styling --------- Co-authored-by: Jason Rasmussen <jrasm91@gmail.com> Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
|
I think activity icons shouldn't be visible while slideshow. Can you please hide them? |
* feat: activity * regenerate api * fix: make asset owner unable to delete comment * fix: merge * fix: tests * feat: use textarea instead of input * fix: do actions only if the album is shared * fix: placeholder opacity * fix(web): improve messages UI * fix(web): improve input message UI * pr feedback * fix: tests * pr feedback * pr feedback * pr feedback * fix permissions * regenerate api * pr feedback * pr feedback * multiple improvements on web * fix: ui colors * WIP * chore: open api * pr feedback * fix: add comment * chore: clean up * pr feedback * refactor: endpoints * chore: open api * fix: filter by type * fix: e2e * feat: e2e remove own comment * fix: web tests * remove console.log * chore: cleanup * fix: ui tweaks * pr feedback * fix web test * fix: unit tests * chore: remove unused code * revert useless changes * fix: grouping messages * fix: remove nullable on updatedAt * fix: text overflow * styling --------- Co-authored-by: Jason Rasmussen <jrasm91@gmail.com> Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
Changes made in this PR
This PR introduces Activity.
On shared albums, you can add comments and likes to assets. They can be found in the Activity tab, by clicking on the comment icon on the bottom right.
Comments can be deleted by the authors, the owner of the album.
There's a lot related to this new feature which will come in future PRs such as notifications to be alerted on new reactions (likes & comments), a global activity tab for each shared album, nested comments...
Related FR: #1660
Screenshots
2023-10-29.00-31-59.mp4