Repository navigation
chore(ml): increase spool threshold - #5176
Merged
Merged
Conversation
mertalev
force-pushed
the
chore/ml-increase-spool-threshold
branch
from
November 20, 2023 04:30
8d0e5a1 to
c6d3e1e
Compare
alextran1502
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change intends to fix #5102 by setting the minimum threshold for spooling to 64MiB. The 16MiB limit was meant to be a high enough number that it shouldn't ever come up, but later thumbnail quality options make it feasible to reach this limit. The cause behind #5102 seems to be that Starlette isn't cleaning up spooled files, so further investigation should be done after this PR to understand why.