Repository navigation
fix(web): delete modal z-index - #5416
Merged
Merged
Conversation
Contributor
Author
|
Just added a fix for deleting photos, too, in addition to trashing. I increased the z-index on the delete confirmation modal, because it's currently behind the photo:
|
jrasm91
reviewed
Dec 2, 2023
Comment on lines
+380
to
+386
| if (nextAsset) { | ||
| assetViewingStore.setAssetId(nextAsset); | ||
| } else if (previousAsset) { | ||
| assetViewingStore.setAssetId(previousAsset); | ||
| } else { | ||
| closeViewer(); | ||
| } |
Member
There was a problem hiding this comment.
Is there a reason why we cannot put this logic inside of navigateAssetForward()?
Member
|
It turns out the issue is because of the websocket event, which I fixed in #5493 instead. Also, the code already had logic for The delete modal is a good catch, so I've rebased this PR to include that fix. |
jrasm91
approved these changes
Dec 5, 2023
jrasm91
enabled auto-merge (squash)
December 5, 2023 01:31
jrasm91
disabled auto-merge
December 5, 2023 01:31
jrasm91
enabled auto-merge (squash)
December 5, 2023 01:32
jrasm91
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4954
When trashing a photo, it should move to the next photo automatically. If there is no next photo, then the previous photo, and otherwise close the asset viewer. This matches Google Photos behavior.
The current code does not work because the deleted photo's next asset reference is null after the
deleteAssets(...)call.I'm new to Svelte, all code suggestions are welcome.