Skip to content

feat(web): allow showing hidden people in image asset details view - #5420

Merged
alextran1502 merged 2 commits into
immich-app:mainfrom
brokeh:show-hidden-people
Dec 2, 2023
Merged

alextran1502 merged 2 commits into
immich-app:mainfrom
brokeh:show-hidden-people

Conversation

@brokeh

@brokeh brokeh commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

This makes it possible to easily find people/faces that have accidentally been hidden. Unhiding them still requires clicking on the person to go to their page to unhide them.

 

This adds the show/hide button to the people section header if the photo has hidden people
image

And clicking the button shows the hidden people
image

And the view for when there are no hidden people remains unchanged, with no toggle button.
image

This makes it possible to easily find people/faces that have accidentally been hidden.
Unhiding them still requires clicking on the person to go to their page to unhide them.
@alextran1502
alextran1502 requested a review from martabal December 1, 2023 21:00

@martabal martabal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !

Comment thread web/src/lib/components/asset-viewer/detail-panel.svelte Outdated
Co-authored-by: martin <74269598+martabal@users.noreply.github.com>
@alextran1502 alextran1502 changed the title Allow showing hidden people in image asset details view feat(web): allow showing hidden people in image asset details view Dec 2, 2023
@alextran1502
alextran1502 merged commit a02e911 into immich-app:main Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants