Skip to content

feat(web): UI/UX improvement for date time edit form - #5505

Merged
alextran1502 merged 1 commit into
mainfrom
feat/web-edit-form-styling
Dec 5, 2023
Merged

alextran1502 merged 1 commit into
mainfrom
feat/web-edit-form-styling

Conversation

@alextran1502

@alextran1502 alextran1502 commented Dec 5, 2023 •

Copy link
Copy Markdown
Member
  • Clicking outside the modal no longer closes the modal, to prevent accidental closing when selecting a date or timezone
  • The timezone Dropdown can now be closed by clicking outside and staying open when searching
Before (Light) After (Light)
image image
Before (Dark) After (Dark)
image image

@alextran1502
alextran1502 enabled auto-merge (squash) December 5, 2023 17:19
on:focus={onSearchFocused}
on:blur={onSearchBlurred}
/>
<Dropdown

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To select the timezone you can click on the input field and on the dropdown menu. It does not feel super intuitive.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is unintuitive in this scenario?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about this :

2023-12-05.21-01-02.mp4

prompt="Please select a new date:"
{disabled}
on:confirm={handleConfirm}
on:cancel={handleCancel}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an option to close the modal when you click outside ? I think this should work :

Suggested change
on:cancel={handleCancel}
on:cancel={handleCancel}
on:click-outside={handleCancel}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I purposely remove that because there are so many instance I am editing, clicking out side causes closing the windows

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also hate "click outside" functionality of modal that require clicking/editing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would ESC close it? I find that intuitive, but not every modal has it implemented.

@alextran1502
alextran1502 merged commit 84c5b08 into main Dec 5, 2023
@alextran1502
alextran1502 deleted the feat/web-edit-form-styling branch December 5, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants