Repository navigation
fix(web): grid on people page - #5640
Merged
Merged
Conversation
Deploying with
|
| Latest commit: |
4db5a0d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d7816658.immich.pages.dev |
| Branch Preview URL: | https://fix-grid-people-page.immich.pages.dev |
jrasm91
approved these changes
Dec 13, 2023
jrasm91
left a comment
jrasm91
left a comment
Member
There was a problem hiding this comment.
This seems OK, but you can actually accomplish all of this with css using flex, not with javascript that has to run in the browser and may cause performance issues on slower devices, like phones.
Contributor
Author
The thumbnail width is re-calculated only when the width of the div containing all the thumbnails change. So could be an issue only on screen rotation |
martabal
force-pushed
the
fix/grid-people-page
branch
from
January 9, 2024 01:06
b2ed8a7 to
b27b95a
Compare
Contributor
Author
|
Changed to use grid instead |
Member
|
It's the video updated too or is that the old one? |
Contributor
Author
I just changed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made in this PR
With this PR, the people grid always takes up the full available width and the size of the thumbnails changes depending on the screen size.
Screenshots
2023-12-11.21-23-06.mp4
2023-12-11.21-21-13.mp4