Repository navigation
refactor(server): immich file responses - #5641
Merged
Merged
Conversation
Deploying with
|
| Latest commit: |
8170589
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e56f36e3.immich.pages.dev |
| Branch Preview URL: | https://refactor-immich-file-respons.immich.pages.dev |
danieldietzler
approved these changes
Dec 11, 2023
danieldietzler
left a comment
danieldietzler
left a comment
Member
There was a problem hiding this comment.
Neat. Looks really good to me!
…ich-file-response
mertalev
approved these changes
Dec 12, 2023
bo0tzz
approved these changes
Dec 12, 2023
jonhnet
pushed a commit
to jonhnet/immich
that referenced
this pull request
Dec 15, 2023
* refactor(server): immich file response * chore: open api * chore: tests * chore: fix logger import --------- Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all
res.sendFilelogic to an interceptor that transformsImmichFileResponseclasses intores.sendFilecalls.