Skip to content

fix(mobile): Fix upload hang on iOS when deleting stale files - #5658

Merged
alextran1502 merged 2 commits into
mainfrom
fix/mobile-upload-hang-ios
Dec 12, 2023
Merged

alextran1502 merged 2 commits into
mainfrom
fix/mobile-upload-hang-ios

Conversation

@alextran1502

Copy link
Copy Markdown
Member

Fixed issue with file and livePhotoFile never get set back to null, therefore redeleting file that have been deleted and causing file not found error

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Dec 12, 2023 •

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ba1c25
Status: ✅  Deploy successful!
Preview URL: https://491277c6.immich.pages.dev
Branch Preview URL: https://fix-mobile-upload-hang-ios.immich.pages.dev

View logs

@shenlong-tanwen

shenlong-tanwen commented Dec 12, 2023 •

Copy link
Copy Markdown
Member

Ah, good catch. But moving the file and livePhotofile variables to inside the for loop should have the same effect instead of manually setting them to null and the additional try catch. We still can change the sync method to the async equivalent and await on it though

@alextran1502

Copy link
Copy Markdown
Member Author

@shenlong-tanwen Done

@alextran1502
alextran1502 merged commit c7df800 into main Dec 12, 2023
@alextran1502
alextran1502 deleted the fix/mobile-upload-hang-ios branch December 12, 2023 17:36
jonhnet pushed a commit to jonhnet/immich that referenced this pull request Dec 15, 2023
…-app#5658)

* fix(mobile): Fix upload hang on iOS when deleting stale files

* Cleaner fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants