Repository navigation
chore: svelte-kit-2 - #6103
Merged
Merged
chore: svelte-kit-2#6103
Conversation
jrasm91
force-pushed
the
deps/svelte-kit-2
branch
from
January 1, 2024 19:38
361f50e to
c16a73c
Compare
Deploying with
|
| Latest commit: |
c959b16
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bb43cedd.immich.pages.dev |
| Branch Preview URL: | https://deps-svelte-kit-2.immich.pages.dev |
jrasm91
force-pushed
the
deps/svelte-kit-2
branch
from
January 18, 2024 04:37
c16a73c to
2f25403
Compare
jrasm91
marked this pull request as ready for review
January 18, 2024 04:53
jrasm91
force-pushed
the
deps/svelte-kit-2
branch
from
January 18, 2024 05:15
c77277c to
c959b16
Compare
martabal
approved these changes
Jan 20, 2024
danieldietzler
approved these changes
Jan 20, 2024
danieldietzler
left a comment
danieldietzler
left a comment
Member
There was a problem hiding this comment.
LGTM! Can we have a linting rule that enforces type imports if we only use the import as a type and not as a value?
alextran1502
approved these changes
Jan 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to svelte kit 2 and vite 5.