Repository navigation
chore: build API with esnext target - #6926
Merged
Merged
Conversation
Collaborator
|
Is it preferable to use esnext or to fix it to something like es2022? |
etnoy
approved these changes
Feb 5, 2024
jrasm91
approved these changes
Feb 5, 2024
Collaborator
Author
|
esnext is best for packages like the API that aren't used directly, but are included and built as part of an application (the web package and CLI package in this case). When we build the web and CLI those packages specify their own target and compile the API in a way that works to ensure support for older browsers or older versions of Node. |
danieldietzler
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a bunch of polyfill code from the API that's unnecessary. The CLI and web projects are built with Vite and support for any newer features will already be added at that time if needed.
This should make the web frontend load a bit faster. I didn't benchmark the web project, but for reference here's the output difference for the CLI
Size of the CLI on
main:dist/index.js 1,088.98 kB
Size of CLI with this PR:
dist/index.js 760.50 kB