Skip to content

feat(web): lazy load photo sphere viewer - #7057

Merged
alextran1502 merged 2 commits into
immich-app:mainfrom
benmccann:lazy-load-panoramas
Feb 12, 2024
Merged

alextran1502 merged 2 commits into
immich-app:mainfrom
benmccann:lazy-load-panoramas

Conversation

@benmccann

Copy link
Copy Markdown
Collaborator

Are there any panoramas in the demo instance? I didn't see a way to search for panoramas, so wasn't sure how to find one to test and check that I didn't break anything.

Before:

.svelte-kit/output/client/_app/immutable/chunks/asset-viewer.bSlvLiFG.js               1,581.26 kB │ gzip: 433.21 kB

After:

.svelte-kit/output/client/_app/immutable/chunks/photo-sphere-viewer-adapter.ctx2RvS1.js     566.44 kB │ gzip: 148.17 kB
.svelte-kit/output/client/_app/immutable/chunks/asset-viewer.9FWEg5V5.js                  1,011.00 kB │ gzip: 283.47 kB

@benmccann benmccann changed the title feat: lazy load photo sphere viewer feat(web): lazy load photo sphere viewer Feb 12, 2024

@mertalev mertalev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a huge difference. Nicely done!

Comment thread web/src/lib/components/asset-viewer/panorama-viewer.svelte Outdated
@alextran1502
alextran1502 merged commit b43cadc into immich-app:main Feb 12, 2024
@benmccann
benmccann deleted the lazy-load-panoramas branch February 12, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants