Repository navigation
fix(web): asset viewer navigation buttons - #7888
Merged
Merged
Conversation
michelheusschen
commented
Mar 12, 2024
michelheusschen
commented
Collaborator
- Show cursor as pointer when hovering over clickable navigation area
- Improve accessibility
- Remove unused keydown event
Deploying with
|
| Latest commit: |
bf3f832
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a5382996.immich.pages.dev |
| Branch Preview URL: | https://fix-web-asset-viewer-navigat.immich.pages.dev |
jrasm91
reviewed
Mar 12, 2024
jrasm91
left a comment
jrasm91
left a comment
Member
There was a problem hiding this comment.
Why do we need to wrap the button in a div and have the click handler be in the div and not the button?
Collaborator
Author
|
That allows focusing the button and not the whole clickable area (white border in image for illustration). The click event from the button bubbles up to the
|
jrasm91
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
