Skip to content

fix(web): Move stack slideshow container higher in the DOM - #8998

Merged
alextran1502 merged 1 commit into
immich-app:mainfrom
Snowknight26:fix-asset-viewer-stack-navigation
Apr 25, 2024
Merged

alextran1502 merged 1 commit into
immich-app:mainfrom
Snowknight26:fix-asset-viewer-stack-navigation

Conversation

@Snowknight26

Copy link
Copy Markdown
Collaborator

This removes the need to define a bottom margin on the next/previous navigation elements, and renders the stack slideshow above the navigation elements, so that the stack slideshow is always interactable.

Probably fixes #8928.

@Snowknight26 Snowknight26 changed the title Move stack slideshow container higher in the DOM fix(web): Move stack slideshow container higher in the DOM Apr 21, 2024
@Snowknight26

Copy link
Copy Markdown
Collaborator Author

Whoopsies, thought I was making this PR on my forked repo, but oh well, let's roll with it. Haven't tested it because I don't really know Svelte.

@alextran1502 alextran1502 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and easy, thank you for the fix

@alextran1502
alextran1502 merged commit 0b3373c into immich-app:main Apr 25, 2024
@Snowknight26
Snowknight26 deleted the fix-asset-viewer-stack-navigation branch April 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image viewer next image link (left arrow) covers thumbnails when viewing stacked images

2 participants