Repository navigation
chore(mobile): add toast notification for "Download Started" - #9023
Merged
Merged
Conversation
Member
|
Thank you for your contribution, you will only need to add the translation string to |
alextran1502
approved these changes
Apr 23, 2024
alextran1502
changed the title
alextran1502
enabled auto-merge (squash)
April 23, 2024 13:11
Add Toast notification for mobile download started. Added new placeholder in each language file - populated with best estimate translations.
auto-merge was automatically disabled
April 24, 2024 03:00
Head branch was pushed to by a user without write access
DeadEnded
force-pushed
the
mobile/toast-dl-started
branch
from
April 24, 2024 03:00
6d6029a to
2ffae97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently started self hosting Immich and using the mobile Android app (fantastic work being done by the way!). We recently noticed that when we started a download in the app - nothing happened. Downloading large files (long videos) gave no feedback until the download was completed.
So, I have made an attempt to add a toast notification at the start of the download to signal that the download did indeed start so the user has confirmation that they initiated the download. I have Google Translated as many of the languages as I felt comfortable with the results of. If I should remove these and let a native speaker do their languages translations (so nothing is mistranslated into something inappropriate) please let me know.
I am a novice, but very much appreciate the projects I use and contribute when I can. Please let me know if anything needs changed/fixed/removed, etc. and I'm happy to do the work!
Thank you - Cheers!
DeadEnd