[ConnerWithAnE]

Description

Fixes #9015

This alters the appBar in the home page. I removed the ternary if statement which was checking if multi-selection is enabled. I see the value in removing the bar to gain space but it does make the UI feel weird. Perhaps it could be a setting that can be added later if users want.

This alters the HomePage() widget return. The HomePage() is now a Stack which allows the MultiselectGrid() to scroll behind it. The page no longer shifts when an asset is selected and the ImmichAppBar() animates out to the top as show in the example given by @waclaw66. This only affects the home page as there is a check in the ImmichAssetGridView() which checks if the current tab is index 0 and the Route is one of the main tabs within the TabController. If both of those checks come up true padding is added to accommodate the AppBar adding some extra space. The RefreshIndicator() also has an offset added conditionally.

How Has This Been Tested?

I ran flutter test and had no issues, I also ran it on an android device. I am unable to test IOS but I have no reason to believe anything would be different on either OS. I checked all views which use the asset grid and only saw the changes take effect on the main page.

[waclaw66]

Thanks for the PR. One remark, it would be nice if you could achieve to replace ImmichAppBar with a transparent bar to extend the surface height in the similar way as GPhotos does.

Screen_Recording_20240423_124122_Photos.mp4_out.mp4

[ConnerWithAnE]

Thanks for the PR. One remark, it would be nice if you could achieve to replace ImmichAppBar with a transparent bar to extend the surface height in the similar way as GPhotos does.
Screen_Recording_20240423_124122_Photos.mp4_out.mp4

Yea I could give that a go, might need to change the way that the homepage is displayed slightly. Could you possibly post a video example of how the top of the asset view is on google photos when selected? just so I can see how it is handled. I'd appreciate it thanks.

Edit: I think I got it looking pretty good actually, let me know what you think.

[waclaw66]

Edit: I think I got it looking pretty good actually, let me know what you think.

It looks awesome now, exactly as I expected. Thanks!

Screen_Recording_20240424_093547.mp4_out.mp4

[benmccann]

Could you fix the failing format job?

[ConnerWithAnE]

Yup, meant to get to it was just away today. First thing tomorrow I will!

[alextran1502]

Perfect! Thank you very much! Let's fix the format and have it merged

FYI, next time you can allow maintainer to push to the PR and we can help take care of these things

[waclaw66]

@ConnerWithAnE could you please adapt this PR to album viewer as well? There is the same issue with jumping asset grid. I've tried to do on my own, but haven't succeeded. Thanks!

[ConnerWithAnE]

@ConnerWithAnE could you please adapt this PR to album viewer as well? There is the same issue with jumping asset grid. I've tried to do on my own, but haven't succeeded. Thanks!

#9741 This should fix it.