[alextran1502]

• Moved all Isar models to a directory called entities
• Moved all models across the app to a directory called models

[cloudflare-workers-and-pages]

Deploying immich with    Cloudflare Pages

Latest commit:	744fc7d
Status:	✅  Deploy successful!
Preview URL:	https://c9b228b0.immich.pages.dev
Branch Preview URL:	https://chore-mobile-refactor-entiti.immich.pages.dev

View logs

[avidal]

Bit of a drive-by, but should this include a change to the model_template and corresponding block in the README?

[alextran1502]

@avidal Makes sense, we are still working on restructuring that so potentially that template might be gone as well

[jrasm91]

In the server we got rid of the domain folder. Having something similar in mobile might be nice as well. Maybe just folders for entities, services, models, interfaces, and repositories would be better.

[martyfuhry]

• asset_viewer/image_providers could be a top-level module.
• home/ui/asset_grid could just be a top-level module of asset_grid.
• I'm not a fan of the shared module, but it was there before so this doesn't need to address that now. I only bring it up in case others have better ideas what to do with it.
• ui and view sort of mean the same thing to me when I look at the modules. It seems like ui is made up of composible Widget components while view is made up of pages of the application which compose from the ui. Maybe we can rename view to page?

Thank you for making this massive improvement! It was long overdue.

[martyfuhry]

Maybe this can live in backup/services

[fyfrey]

Looking forward to the restructured code base!

I agree with @jrasm91, instead of another level of nesting (domain), let us directly have folders for entities, models, ... one level higher up.

Also agree with @martyfuhry, but we can do these changes in another PR.

[jrasm91]

A lot of web projects use a routes folder which basically corresponds to application pages. It could make sense to have a folder for top level pages, organized that same way, and then have sub components (like buttons, spinners, asset grid, thumbnail, etc.) in a separate folder.