Repository navigation
feat(web): expand usage of CircleIconButton - #9256
Merged
Merged
Conversation
Collaborator
Author
|
On my mind after this: finding a way to build easy, accessible and reproducible buttons that have both an icon and text. |
jrasm91
approved these changes
May 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increasing the usage of the
CircleIconButtonthroughout immich. Benefits include consistent theming, accessible labeling, and changing colors when hovering with a mouse.Also in this change:
Screenshots
Expand for screenshots
Hover: Search bar button
Hover: album card
How Has This Been Tested?
Visually checked affected icons in both light mode and dark mode.
Checklist: