Skip to content

fix(web): page down shortcut - #9397

Merged
alextran1502 merged 1 commit into
mainfrom
fix/page-down-shortcut
May 11, 2024
Merged

alextran1502 merged 1 commit into
mainfrom
fix/page-down-shortcut

Conversation

@martabal

Copy link
Copy Markdown
Contributor

fixes #9396

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2b3fc8e
Status: ✅  Deploy successful!
Preview URL: https://92afde42.immich.pages.dev
Branch Preview URL: https://fix-page-down-shortcut.immich.pages.dev

View logs

@alextran1502
alextran1502 merged commit 8fdcaba into main May 11, 2024
@alextran1502
alextran1502 deleted the fix/page-down-shortcut branch May 11, 2024 21:49
@oryjkov

oryjkov commented May 13, 2024

Copy link
Copy Markdown

I would have expected PgDn to scroll down by a single page of content, not jump to the bottom of the content, as it does with this change. Effectively it now does what the End key is already doing.

I don't think fixes #9396

@martabal

Copy link
Copy Markdown
Contributor Author

From the beginning, I had in mind that the behavior was to go to the very bottom/very top of the page. I guess the behavior you describe is good too (probably even better). Google Photos doesn't seem to move from one time bucket to another, it's just scrolling through more rows, but that has nothing to do with time buckets.

@oryjkov

oryjkov commented May 14, 2024

Copy link
Copy Markdown

google photos scrolls up/down by a single page of content when PgUp/PgDn is pressed (I tried in the Timeline and Album views). IMO that's what these keys should do.

@Snowknight26

Copy link
Copy Markdown
Collaborator

Yep and ideally the browser should handle those without needing to rely on keydown.
#9448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page down doesn't work more than once in timeline

5 participants