Repository navigation
refactor!: port env - #9559
Merged
Merged
refactor!: port env#9559
Conversation
jrasm91
commented
May 17, 2024
| app.useWebSocketAdapter(new WebSocketAdapter(app)); | ||
|
|
||
| await (host ? app.listen(port, host) : app.listen(port)); | ||
| await app.listen(0); |
Member
Author
There was a problem hiding this comment.
we don't actually use this port, so just pick a random one. (TODO: remove listening entirely in the future)
mertalev
previously requested changes
May 17, 2024
Deploying immich with
|
| Latest commit: |
7096145
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41b3cd1a.immich.pages.dev |
| Branch Preview URL: | https://refactor-port-env.immich.pages.dev |
bo0tzz
approved these changes
May 17, 2024
jrasm91
force-pushed
the
refactor/port-env
branch
from
May 17, 2024 16:29
6abf0ad to
7096145
Compare
yparitcher
added a commit
to yparitcher/immich
that referenced
this pull request
Apr 16, 2025
per NextJs docs `app.init()` should be used instead of `app.listen()` if the application is not accepting http requests. Fixes: immich-app#9559
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMMICH_PORTandIMMICH_HOSTeverywhere.