Repository navigation
refactor: deprecate /server-info and replace with /server-info/storage - #9645
Merged
Merged
Conversation
Deploying immich with
|
| Latest commit: |
14849a9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a7544c4.immich.pages.dev |
| Branch Preview URL: | https://refactor-server-info-storage.immich.pages.dev |
jrasm91
reviewed
May 21, 2024
| "/server-info": { | ||
| "get": { | ||
| "deprecated": true, | ||
| "description": "This property was deprecated in v1.106.0", |
Member
There was a problem hiding this comment.
oh this might be a little bug that it should say endpoint instead of property. looks like it uses the same description for both.
Member
There was a problem hiding this comment.
Yup, fixing this is actually not super-trivial. I think I'd prefer a neutral name that works for both properties and endpoints
jrasm91
approved these changes
May 21, 2024
danieldietzler
approved these changes
May 21, 2024
danieldietzler
left a comment
danieldietzler
left a comment
Member
There was a problem hiding this comment.
Except for the tests this looks good ;)
Member
Author
I'll fix those in the morning, brain was mush by the time this was done 🤣 |
zackpollard
force-pushed
the
refactor/server-info-storage-info
branch
from
May 22, 2024 09:20
40c4fb3 to
14849a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/server-info root endpoint was used for storage info only, moving this to a more sensible place