Repository navigation
fix(web): show api key copy button in Firefox - #9704
Merged
Merged
Conversation
bo0tzz
approved these changes
May 23, 2024
jrasm91
approved these changes
May 23, 2024
jrasm91
left a comment
jrasm91
left a comment
Member
There was a problem hiding this comment.
Noice. Why in the world were we requiring "copy image to clipboard" for copy text lol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since all other text copy buttons do not have a check either, I removed this.
writeText()compatibility: https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/writeText#browser_compatibilityAn alternative would be to check
navigator.clipboard.writeTextfor all buttons, but since there is a good error message that encourages people to use https, I don't think there is a need to hide the buttons.