Repository navigation
fix(web): high resolution image on zoom - #9818
Merged
Merged
Conversation
Deploying immich with
|
| Latest commit: |
0b726b7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c78008c.immich.pages.dev |
| Branch Preview URL: | https://fix-web-high-resolution-imag.immich.pages.dev |
Member
|
@midzelis FYI |
alextran1502
approved these changes
May 28, 2024
…-resolution-image-on-zoom
jrasm91
approved these changes
May 28, 2024
Collaborator
|
I'll fix high resolution image using the non-blob URLs change in the earlier PR. Sorry about that. I think there is merit/value in not using blob URLs for the images. You get a lot of browser-native caching behavior if you use ordinary URLs. You also get the ability to copy an images URL. Unverified - but I bet it also uses less memory, since the browser doesn't need to copy the image from the cache to a byte blob. Also, the original code is massively overcomplicated for what it does. Stay tuned for a fix in a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9684 added support for replacing assets but also made several changes to
PhotoViewer, which causes high resolution images to no longer load when zooming in.Resolved by reverting these changes, but added reloading when the checksum changes. Unit tests are added to cover this functionality.