Skip to content

fix(NewClient): support https:// URLs - #277

Merged
lidel merged 2 commits into
masterfrom
pr-276
Jan 10, 2025
Merged

lidel merged 2 commits into
masterfrom
pr-276

Conversation

@lidel

@lidel lidel commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

This is alternative way of fixing issue from #276

We don't hardcode any specific ports, but assume http:// (backward-compatible behavior) unless https:// is passed (then we keep it as-is).

ipfs/kubo#10659 will pass https:// if multiaddr ending with /https or /tls/http is passed via ipfs --api

We don't hardcode any specific ports, but assume `http://`
(backward-compatible behavior)  unless `https://` is passed (then we
keep it as-is).
this is backward-compatible fix, ok to just bump patch
@github-actions

Copy link
Copy Markdown

Suggested version: 0.14.1

Comparing to: v0.14.0 (diff)

Changes in configuration file(s):

diff --git a/go.mod b/go.mod
index 936b4a6..1b06924 100644
--- a/go.mod
+++ b/go.mod
@@ -9,7 +9,7 @@ require (
 	github.com/ipfs/go-log v1.0.5
 	github.com/rs/cors v1.11.1
 	github.com/texttheater/golang-levenshtein v1.0.1
-	golang.org/x/term v0.24.0
+	golang.org/x/term v0.25.0
 )
 
 require (

gorelease says:

gorelease: go: loading module retractions for go.opentelemetry.io/otel/exporters/otlp/otlptrace@v1.27.0: module go.opentelemetry.io/otel/exporters/otlp/otlptrace@v1.33.0 requires go >= 1.22.7 (running go 1.22.0)
go: loading module retractions for go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc@v1.27.0: module go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc@v1.33.0 requires go >= 1.22.7 (running go 1.22.0)
go: loading module retractions for go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp@v1.27.0: module go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp@v1.33.0 requires go >= 1.22.7 (running go 1.22.0)
go: loading module retractions for honnef.co/go/tools@v0.0.1-2019.2.3: module honnef.co/go/tools@v0.5.1 requires go >= 1.22.1 (running go 1.22.0)

gocompat says:

HEAD is now at 7f9933b chore: release v0.14.0 (#269)
Previous HEAD position was 7f9933b chore: release v0.14.0 (#269)
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant