Skip to content

filestore: verify option to remove bad blocks - #7474

Merged
gammazero merged 11 commits into
ipfs:masterfrom
ivan386:ivan386/filestore-fix
Jun 4, 2025
Merged

gammazero merged 11 commits into
ipfs:masterfrom
ivan386:ivan386/filestore-fix

Conversation

@ivan386

@ivan386 ivan386 commented Jun 13, 2020

Copy link
Copy Markdown
Contributor

Verify objects in filestore and remove bad links

License: MIT
Signed-off-by: Ivan ivan386@users.noreply.github.com

@Stebalien Stebalien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you write a sharness test? (test/sharness)

Comment thread core/commands/filestore.go Outdated
Comment thread core/commands/filestore.go Outdated
Comment thread core/commands/filestore.go Outdated
Comment thread core/commands/filestore.go Outdated
@jacobheun

Copy link
Copy Markdown
Contributor

@ivan386 can you check the linter issue here?

@ivan386

ivan386 commented Jul 10, 2020

Copy link
Copy Markdown
Contributor Author

@jacobheun I don't have access to it without login.

@aschmahmann

Copy link
Copy Markdown
Contributor

@ivan386 you can run the linter locally by using golangci-lint run ./... (https://github.com/golangci/golangci-lint).

The linter errors were regarding unchecked errors from use of fs.FileManager().DeleteBlock()

@gammazero
gammazero requested a review from a team as a code owner June 3, 2025 22:13
@gammazero

Copy link
Copy Markdown
Contributor

@gammazero updated PR:

  • Only include remove blocks action in output if removing blocks
  • Update command documentation
  • Wrote sharness test
  • Fixed broken sharness tests
  • Fixed linter warning about missed error check

@hsanjuan hsanjuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor nits

Comment thread core/commands/filestore.go Outdated
Comment thread core/commands/filestore.go Outdated
Comment thread core/commands/filestore.go Outdated
gammazero and others added 3 commits June 4, 2025 13:35
Co-authored-by: Hector Sanjuan <code@hector.link>
Co-authored-by: Hector Sanjuan <code@hector.link>
@gammazero
gammazero merged commit d39cb7f into ipfs:master Jun 4, 2025
@gammazero gammazero changed the title Ivan386/filestore fix filestore: verify option to remove bad blocks Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants