pollEndpoint: improve error output - #952
Merged
Merged
Conversation
Contributor
Author
|
re-opened to get the tests running again but it only affected the The faillure was a known fluke: ps: rebased |
cryptix
force-pushed
the
tests/pollEndpointErrors
branch
from
March 22, 2015 13:28
0e211ff to
6350cff
Compare
jbenet
added a commit
that referenced
this pull request
Mar 22, 2015
pollEndpoint: improve error output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After seeing the comments on #933, I realized the output of the errors was not good.
It now prints the errors as strings. i.e.:
instead of