Skip to content

pollEndpoint: improve error output - #952

Merged
jbenet merged 1 commit into
masterfrom
tests/pollEndpointErrors
Mar 22, 2015
Merged

jbenet merged 1 commit into
masterfrom
tests/pollEndpointErrors

Conversation

@cryptix

@cryptix cryptix commented Mar 21, 2015

Copy link
Copy Markdown
Contributor

After seeing the comments on #933, I realized the output of the errors was not good.

It now prints the errors as strings. i.e.:

error="Get http://127.0.0.1:10044/version: dial tcp 127.0.0.1:10044: connection refused"

instead of

error="wrong url or endpoint error from http.Get() &url.Error{Op:\"Get\", RL:\"http://127.0.0.1:5836/version\", Err:(*net.OpError)(0xc208032600)}"

@btc btc added the status/in-progress In progress label Mar 21, 2015
@cryptix cryptix closed this Mar 21, 2015
@btc btc removed the status/in-progress In progress label Mar 21, 2015
@cryptix cryptix reopened this Mar 21, 2015
@btc btc added the status/in-progress In progress label Mar 21, 2015
@cryptix

cryptix commented Mar 22, 2015

Copy link
Copy Markdown
Contributor Author

re-opened to get the tests running again but it only affected the travis-ci/pr not /push.

The faillure was a known fluke:

--- FAIL: TestBootstrap (1.23 seconds)
    dht_test.go:314: connecting 30 dhts in a ring
    dht_test.go:77: dial attempt failed
01:38:44.557 CRITI   boguskey: TestBogusPrivateKey.Sign -- this better be a test! <autogenerated>:21
FAIL
FAIL    github.com/jbenet/go-ipfs/routing/dht   5.049s

ps: rebased

@cryptix
cryptix force-pushed the tests/pollEndpointErrors branch from 0e211ff to 6350cff Compare March 22, 2015 13:28
jbenet added a commit that referenced this pull request Mar 22, 2015
@jbenet
jbenet merged commit 41e93f6 into master Mar 22, 2015
@jbenet jbenet removed the status/in-progress In progress label Mar 22, 2015
@jbenet
jbenet deleted the tests/pollEndpointErrors branch March 22, 2015 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants