Skip to content

Fix incorrect playback reporting with burn in subtitles enabled - #640

Merged
1hitsong merged 3 commits into
masterfrom
fix/jf-638-incorrect-playback-reporting
Dec 27, 2025
Merged

1hitsong merged 3 commits into
masterfrom
fix/jf-638-incorrect-playback-reporting

Conversation

@jimdogx

@jimdogx jimdogx commented Dec 27, 2025 •

Copy link
Copy Markdown
Member

Fix dashboard incorrectly reporting that video is direct playing when it is indeed being transcoded.

Changes

Captures the new play session id when we re-post playback info to the server.

Issues

Fixes #638
Fixes #616

@jimdogx
jimdogx requested a review from a team as a code owner December 27, 2025 05:29
@1hitsong

Copy link
Copy Markdown
Member

Looks like it's working! Can you add an entry in the What's New content so peeps know this was fixed?

@jimdogx

jimdogx commented Dec 27, 2025

Copy link
Copy Markdown
Member Author

Can you add an entry in the What's New content so peeps know this was fixed?

Thanks, I always forget to do that 😆

@1hitsong
1hitsong merged commit d833674 into master Dec 27, 2025
1 check passed
@1hitsong
1hitsong deleted the fix/jf-638-incorrect-playback-reporting branch December 27, 2025 14:06
@cewert

cewert commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

It seems like the root bug is that we are posting playback info twice for the same video/session, is that really necessary? Does the admin dashboard show "activity" for both of these play sessions or is one ignored?

Mentioned in #624 I also noticed when I play any file, it will scan twice before it plays and in the activity section, it says Phil has finished playing ___, then it says phil is playing ___. Not sure if that's intended.

@jimdogx

jimdogx commented Dec 27, 2025

Copy link
Copy Markdown
Member Author

I do believe that is correct (client is posting playback info more than once). The code needs a refactor, but this at least fixes it until the next version 👍

@cewert

cewert commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

Strongly disagree. If this approach is correct, then why would it need refactored? We have over a week until the holiday blackout is over, why the rush?

The second API call was introduced in #591. The PR tries to mimic web client behavior but I don't believe the web client is posting play back info twice like this client does.

@jimdogx jimdogx mentioned this pull request Jan 7, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jellyfin Dashboard Reproting Driect Play when really Transcoding (Maybe Only Roku Client) When audio-only transcoding, dashbord says "direct playing"

3 participants