Repository navigation
Fix incorrect playback reporting with burn in subtitles enabled - #640
Conversation
|
Looks like it's working! Can you add an entry in the What's New content so peeps know this was fixed? |
Thanks, I always forget to do that 😆 |
|
It seems like the root bug is that we are posting playback info twice for the same video/session, is that really necessary? Does the admin dashboard show "activity" for both of these play sessions or is one ignored? Mentioned in #624 |
|
I do believe that is correct (client is posting playback info more than once). The code needs a refactor, but this at least fixes it until the next version 👍 |
|
Strongly disagree. If this approach is correct, then why would it need refactored? We have over a week until the holiday blackout is over, why the rush? The second API call was introduced in #591. The PR tries to mimic web client behavior but I don't believe the web client is posting play back info twice like this client does. |
Fix dashboard incorrectly reporting that video is direct playing when it is indeed being transcoded.
Changes
Captures the new play session id when we re-post playback info to the server.
Issues
Fixes #638
Fixes #616