Skip to content

ci: bump node versions to 22-26 - #1972

Merged
yowainwright merged 3 commits into
masterfrom
node-26
Aug 23, 2026
Merged

yowainwright merged 3 commits into
masterfrom
node-26

Conversation

@jonathanong

@jonathanong jonathanong commented May 25, 2026 •

Copy link
Copy Markdown
Member

Summary by Sourcery

Run CI against newer Node.js versions and update the coverage tooling dependencies.

CI:

  • Update the Node.js CI matrix to test versions 22.x, 24.x, and 26.x.

Chores:

  • Upgrade the c8 development dependency and refresh the package lockfile.

Summary by CodeRabbit

  • Chores
    • Updated testing infrastructure to validate compatibility with Node.js versions 22.x, 24.x, and 26.x.
    • Improved development and release reliability through updated tooling configuration and compatibility adjustments.
    • Refreshed automated quality checks to support current Node.js environments and ensure more consistent build and test results.

@coderabbitai

coderabbitai Bot commented May 25, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e3759610-958d-42ed-8ae4-be463ed709ab

📥 Commits

Reviewing files that changed from the base of the PR and between 18c1593 and fe9ba84.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Node.js CI workflow now tests Node.js 22.x, 24.x, and 26.x. The package configuration upgrades the c8 development dependency to ^12.0.0 and removes its npm yargs override.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change to the Node.js CI version matrix.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented May 25, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI to test against newer Node.js runtimes and bumps the c8 dev dependency, with corresponding lockfile refresh.

File-Level Changes

Change Details Files
Update CI Node.js test matrix to target newer supported runtime versions.
  • Change GitHub Actions Node.js matrix from 18/20/22 to 22/24/26
  • Keep existing workflow steps and actions versions unchanged
.github/workflows/node.js.yml
Upgrade c8 dev dependency and refresh npm lockfile.
  • Bump c8 devDependency from ^11.0.0 to ^12.0.0
  • Regenerate package-lock.json to reflect the new c8 version and dependency tree
package.json
package-lock.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider whether dropping Node 18.x and 20.x from the matrix is intentional, as this will stop catching compatibility issues for users still on the current LTS line; if you still support them, keep at least the oldest supported LTS in the CI matrix.
  • If the project defines an engines field or other version constraints, make sure they are updated to match the new 22.x–26.x support range so CI and declared support stay aligned.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider whether dropping Node 18.x and 20.x from the matrix is intentional, as this will stop catching compatibility issues for users still on the current LTS line; if you still support them, keep at least the oldest supported LTS in the CI matrix.
- If the project defines an `engines` field or other version constraints, make sure they are updated to match the new 22.x–26.x support range so CI and declared support stay aligned.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented May 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (9c202e0) to head (1b9e9ea).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1972   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files           9        9           
  Lines        2110     2110           
=======================================
  Hits         2108     2108           
  Misses          2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/node.js.yml (1)

16-16: ⚡ Quick win

Node.js 26.x is officially released (Current), but not yet LTS—align with CI stability intent.

Using node-version: [22.x, 24.x, 26.x] is fine from a release-availability standpoint: Node.js 26 has been released and is actively maintained as the “Current” line in May 2026. However, it’s not LTS yet (LTS starts in October 2026), so if the CI goal is production-grade stability signals, consider testing LTS majors only (or pinning) instead of the non-LTS 26.x.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/node.js.yml at line 16, Update the GitHub Actions matrix
under the node-version key to avoid testing the non-LTS Node 26.x by removing
26.x from the array (or alternatively pinning exact LTS patch versions);
specifically edit the node-version: [22.x, 24.x, 26.x] entry in the workflow to
something like node-version: [22.x, 24.x] (or node-version: [22.20.0, 24.17.0]
if you prefer pinned LTS releases) so CI aligns with production-grade LTS
stability intent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/node.js.yml:
- Line 16: CI matrix is missing the minimum supported Node version: update the
node-version matrix entry (node-version: [22.x, 24.x, 26.x]) to include the
declared minimum (e.g., add 18.x and/or 20.x) so CI validates engines.node, or
alternatively change package.json's engines.node to match the tested minimum
(e.g., ">=22") to keep declarations in sync; modify the node-version array in
the workflow or the engines.node field in package.json accordingly and commit
the matching change.

---

Nitpick comments:
In @.github/workflows/node.js.yml:
- Line 16: Update the GitHub Actions matrix under the node-version key to avoid
testing the non-LTS Node 26.x by removing 26.x from the array (or alternatively
pinning exact LTS patch versions); specifically edit the node-version: [22.x,
24.x, 26.x] entry in the workflow to something like node-version: [22.x, 24.x]
(or node-version: [22.20.0, 24.17.0] if you prefer pinned LTS releases) so CI
aligns with production-grade LTS stability intent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a452be8d-b11c-4c91-8a7e-4985cdb6c849

📥 Commits

Reviewing files that changed from the base of the PR and between 4b12945 and c837aeb.

📒 Files selected for processing (1)
  • .github/workflows/node.js.yml

Comment thread .github/workflows/node.js.yml Resolved

@3imed-jaberi 3imed-jaberi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanong I have fixed the issue with node v26! LGTM, you can merge it 🚀

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

@yowainwright

Copy link
Copy Markdown
Member

@sourcery-ai review please.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path=".github/workflows/node.js.yml" line_range="16" />
<code_context>
     strategy:
       matrix:
-        node-version: [18.x, 20.x, 22.x]
+        node-version: [22.x, 24.x, 26.x]

     steps:
</code_context>
<issue_to_address>
**issue (broader_impact):** The CI matrix no longer tests Node.js 18.x or 20.x even though `package.json` still declares support for every Node.js version `>= 18`, so regressions affecting those supported runtimes can merge undetected.

**Triggers:** When a change remains compatible with Node.js 22+ but breaks on Node.js 18 or 20.

**Suggested fix:** Retain 18.x and 20.x in the matrix, or update the package's `engines.node` declaration to remove those runtimes from the supported range.

```suggestion
        node-version: [18.x, 20.x, 22.x, 24.x, 26.x]
```
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: .github/workflows/node.js.yml:16


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread .github/workflows/node.js.yml Resolved
@yowainwright
yowainwright merged commit 4a191b1 into master Aug 23, 2026
8 checks passed
@yowainwright
yowainwright deleted the node-26 branch August 23, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants