Repository navigation
ci: bump node versions to 22-26 - #1972
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Node.js CI workflow now tests Node.js 22.x, 24.x, and 26.x. The package configuration upgrades the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates CI to test against newer Node.js runtimes and bumps the c8 dev dependency, with corresponding lockfile refresh. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider whether dropping Node 18.x and 20.x from the matrix is intentional, as this will stop catching compatibility issues for users still on the current LTS line; if you still support them, keep at least the oldest supported LTS in the CI matrix.
- If the project defines an
enginesfield or other version constraints, make sure they are updated to match the new 22.x–26.x support range so CI and declared support stay aligned.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider whether dropping Node 18.x and 20.x from the matrix is intentional, as this will stop catching compatibility issues for users still on the current LTS line; if you still support them, keep at least the oldest supported LTS in the CI matrix.
- If the project defines an `engines` field or other version constraints, make sure they are updated to match the new 22.x–26.x support range so CI and declared support stay aligned.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1972 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 9 9
Lines 2110 2110
=======================================
Hits 2108 2108
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/node.js.yml (1)
16-16: ⚡ Quick winNode.js 26.x is officially released (Current), but not yet LTS—align with CI stability intent.
Using
node-version: [22.x, 24.x, 26.x]is fine from a release-availability standpoint: Node.js 26 has been released and is actively maintained as the “Current” line in May 2026. However, it’s not LTS yet (LTS starts in October 2026), so if the CI goal is production-grade stability signals, consider testing LTS majors only (or pinning) instead of the non-LTS26.x.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/node.js.yml at line 16, Update the GitHub Actions matrix under the node-version key to avoid testing the non-LTS Node 26.x by removing 26.x from the array (or alternatively pinning exact LTS patch versions); specifically edit the node-version: [22.x, 24.x, 26.x] entry in the workflow to something like node-version: [22.x, 24.x] (or node-version: [22.20.0, 24.17.0] if you prefer pinned LTS releases) so CI aligns with production-grade LTS stability intent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/node.js.yml:
- Line 16: CI matrix is missing the minimum supported Node version: update the
node-version matrix entry (node-version: [22.x, 24.x, 26.x]) to include the
declared minimum (e.g., add 18.x and/or 20.x) so CI validates engines.node, or
alternatively change package.json's engines.node to match the tested minimum
(e.g., ">=22") to keep declarations in sync; modify the node-version array in
the workflow or the engines.node field in package.json accordingly and commit
the matching change.
---
Nitpick comments:
In @.github/workflows/node.js.yml:
- Line 16: Update the GitHub Actions matrix under the node-version key to avoid
testing the non-LTS Node 26.x by removing 26.x from the array (or alternatively
pinning exact LTS patch versions); specifically edit the node-version: [22.x,
24.x, 26.x] entry in the workflow to something like node-version: [22.x, 24.x]
(or node-version: [22.20.0, 24.17.0] if you prefer pinned LTS releases) so CI
aligns with production-grade LTS stability intent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a452be8d-b11c-4c91-8a7e-4985cdb6c849
📒 Files selected for processing (1)
.github/workflows/node.js.yml
3imed-jaberi
left a comment
There was a problem hiding this comment.
@jonathanong I have fixed the issue with node v26! LGTM, you can merge it 🚀
Signed-off-by: jongleberry <jonathanrichardong@gmail.com>
|
@sourcery-ai review please. |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/node.js.yml" line_range="16" />
<code_context>
strategy:
matrix:
- node-version: [18.x, 20.x, 22.x]
+ node-version: [22.x, 24.x, 26.x]
steps:
</code_context>
<issue_to_address>
**issue (broader_impact):** The CI matrix no longer tests Node.js 18.x or 20.x even though `package.json` still declares support for every Node.js version `>= 18`, so regressions affecting those supported runtimes can merge undetected.
**Triggers:** When a change remains compatible with Node.js 22+ but breaks on Node.js 18 or 20.
**Suggested fix:** Retain 18.x and 20.x in the matrix, or update the package's `engines.node` declaration to remove those runtimes from the supported range.
```suggestion
node-version: [18.x, 20.x, 22.x, 24.x, 26.x]
```
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: .github/workflows/node.js.yml:16
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Run CI against newer Node.js versions and update the coverage tooling dependencies.
CI:
Chores:
Summary by CodeRabbit