backend: refactor StartHeadlampServer by extracting runServer

[srajang1805]

Summary

This PR refactors StartHeadlampServer by extracting the server startup and shutdown logic into a dedicated runServer helper.

The extraction removes the existing //nolint:funlen suppression while preserving the original behavior. StartHeadlampServer now focuses on orchestration, with the server lifecycle encapsulated in a smaller helper.

Changes

• Extracted runServer(config, cancel, handler) from StartHeadlampServer.

• Moved:

  • HTTP server creation
  • TLS/plain HTTP startup
  • Graceful shutdown handling
  • Server error handling

• Removed the //nolint:funlen suppression from StartHeadlampServer.

• No functional changes or API changes.

Advantages

• Removes the need for the //nolint:funlen suppression.
• Improves separation of responsibilities between orchestration and server lifecycle management.
• Makes StartHeadlampServer easier to read and maintain.
• Keeps the server startup logic localized in a dedicated helper.
• Preserves existing runtime behavior.

Verification

• Relevant tests passed

Notes for Reviewers

• This is intended to be a refactoring only with no behavioral changes.
• The extracted helper is unexported and does not modify the public API.
• The diff is intentionally small and primarily consists of moving existing logic into runServer.
• The primary goal is to improve readability and eliminate the //nolint:funlen suppression.

[illume]

Thanks for these changes.

Can you please have a look at the git commits to see if they meet the contribution guidelines? We use a Linux kernel style of git commits. See the contributing guide for general context, and please see previous git commits with git log for examples.

Commits that need attention

• backend: Extract runServer from StartHeadlampServer, drop nolint:funlen — Only one file changed inside backend/; add a sub-area so it's clear what was touched (e.g. backend: ComponentName: description).

Commit guidelines

• Use atomic commits focused on a single change.
• Use the title format <area>: <Description of changes> — description must start with a capital letter.
• Keep the title under 72 characters (soft requirement).
• Explain the intention and why the change is needed.
• Make commit titles meaningful and describe what changed.
• Do not add code that a later commit rewrites; squash or reorder commits instead.
• Do not include Fixes #NN in commit messages.

Good examples:

• frontend: HomeButton: Fix so it navigates to home
• backend: config: Add enable-dynamic-clusters flag

[Copilot]

Pull request overview

This PR refactors the backend server startup path by extracting the HTTP server lifecycle (listen + graceful shutdown + error handling) from StartHeadlampServer into a new unexported helper, runServer, to improve readability and remove the //nolint:funlen suppression without changing behavior.

Changes:

• Removed the //nolint:funlen suppression on StartHeadlampServer by extracting the server lifecycle logic.
• Added runServer(config, cancel, handler) to encapsulate server creation, ListenAndServe(TLS), graceful shutdown wiring, and startup error handling.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[illume]

🎉 thanks!

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, srajang1805

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [illume]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment