tools: add support for specifying other container engines

[slashpai]

What this PR does / why we need it:
Add support for specifying other container engines. This will help for developers who use container engines other than docker

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

Hi @slashpai. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[slashpai]

cc @dgrisonnet @RainbowMango

[dgrisonnet]

/ok-to-test

[rexagod]

/ok-to-test

[RainbowMango]

This will help for developers who use container engines other than docker

For example? Or which container engine you are using? And have you tested it?

[slashpai]

This will help for developers who use container engines other than docker

For example? Or which container engine you are using? And have you tested it?

I use podman. It works after setting the env variable added in Makefile now. I wanted to fix the test-image job as well to run it locally on Mac. Working on that 🙂

[slashpai]

as dpkg works on Debian based systems only it was not working to run locally on mac, should be the case for other systems too which doesn't have dpkg package

[slashpai]

Kindly review when you get a chance

[RainbowMango]

Generally looks good to me.
But I'm not sure if we are going to support multiple container engines cause they need more maintenance efforts.

[RainbowMango]

Shall we add comments explaining that we currently test it with docker only?

[slashpai]

default is docker for ci runs similar to ARCH?=amd64 set above, not sure if we need to add specific comments for that.

The idea of having this variable is for those who use different container engine in local machine they need the change to test changes and update docs/command-line-flags.txt after regnerating.

[slashpai]

We don't need anything else other than having the variable in Makefile so those who use other than docker it's easier 🙂

[richabanker]

/triage accepted
/assign @RainbowMango

[RainbowMango]

Need the maintainer to make a decision about whether should we support other container engines than docker.

/assign @serathius
to take a look?

[serathius]

I don't have concerns about allowing use of alternative container runtimes assuming they have the same cli interface. However, @slashpai wouldn't be just easier for you to have alias docker=podman?

[slashpai]

I don't have concerns about allowing use of alternative container runtimes assuming they have the same cli interface. However, @slashpai wouldn't be just easier for you to have alias docker=podman?

I had already tried that but that didn't work while running make test-image-all

[slashpai]

─ make test-image-all                                                                                           ─╯
# Pull base image explicitly. Keep in sync with Dockerfile, otherwise
# GCB builds will start failing.
docker pull golang:1.24.2
make[1]: docker: No such file or directory
make[1]: *** [container] Error 1
make: *** [test-image-all] Error 2
╭─░▒▓ ~/github.com/slashpai/metrics-server  update-deps *19 ············· 2 х  3.12.7 Py  1.24.2 Go  13:04:12 ▓▒░─╮
╰─ alias docker=podman                                                                                           ─╯
╭─░▒▓ ~/github.com/slashpai/metrics-server  update-deps *19 ··············· ✔  3.12.7 Py  1.24.2 Go  13:04:19 ▓▒░─╮
╰─ make test-image-all                                                                                           ─╯
# Pull base image explicitly. Keep in sync with Dockerfile, otherwise
# GCB builds will start failing.
docker pull golang:1.24.2
make[1]: docker: No such file or directory
make[1]: *** [container] Error 1
make: *** [test-image-all] Error 2

[serathius]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RainbowMango]

Need another lgtm
/lgtm