Repository navigation
feat(core): Remove EOL Python 3.10 support - #41267
Conversation
16475fc to
a913a2f
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
a913a2f to
769b332
Compare
769b332 to
f6c247d
Compare
Bicheng (BichengWang)
left a comment
There was a problem hiding this comment.
[P1] test-dependents cannot use its own matrix to define python-version.
At head f6c247de40e56d0747fead679ad1a5177fa0930c, the new python-version: ${{ matrix.python-version }} in strategy.matrix makes the Integration Tests workflow invalid. The matrix context is unavailable while GitHub evaluates strategy, so this blocks scheduled and manually dispatched runs before the jobs start. GitHub's context availability reference lists only github, needs, vars, and inputs for this location.
The compute-matrix output already contains the Python versions. This replacement passes validation and preserves the override:
python-version: ${{ fromJSON(needs.compute-matrix.outputs.matrix).python-version }}I ran actionlint 1.7.12 with -shellcheck= -pyflakes= on the complete workflow: the PR base (c088db971097f0f12c7b8c30d473e8dbde09c823) and current master (b7b942a7ffd3206e1b572f4d0639377bca4750d7) pass; this head fails with context "matrix" is not allowed here; a temporary copy with the replacement passes. I also executed the head's matrix-generation shell step offline: it emits ["3.11", "3.14"] by default and ["3.12"] with that override.
This review is scoped to the integration workflow change.
f6c247d to
3522902
Compare
|
Fixed integration test. |
| py_versions = ["3.11", "3.12", "3.13", "3.14"] | ||
| else: | ||
| py_versions = ["3.10", "3.14"] | ||
| py_versions = ["3.11", "3.14"] |
There was a problem hiding this comment.
Most libs depend on core so we can't test them in 3.10 anymore.
7f5a1e2 to
d1a472a
Compare
# Conflicts: # .github/scripts/check_diff.py # libs/core/pyproject.toml # libs/core/tests/unit_tests/document_loaders/test_langsmith.py # libs/core/uv.lock
ccurme (ccurme)
left a comment
There was a problem hiding this comment.
Thank you so much for this!
Uh oh!
There was an error while loading. Please reload this page.